search

FireDynamics / fdsreader

Python reader for FDS data
GNU General Public License v3.0
44 stars 18 forks source link

_devices variable not available any more #45

Closed lu-kas closed 1 year ago

lu-kas commented 1 year ago

Hi,

I think the load devices function is broken:

https://github.com/FireDynamics/fdsreader/blob/16f4d3e2988ef765c9d9fd63aa73a5151ee015d7/fdsreader/simulation.py#L936

It references to self._devices, which are not available any more. Renaming _devices to devices seems to solve the problem. Are there any consequences in this fix which I do not see?

Are there any other places in the code which reference to the deleted Simulation class variables?

JanVogelsang commented 1 year ago

Strange, but I will look into that. It might very well break something, it did for the particles at least. Should not be hard to fix though.

lu-kas commented 1 year ago

Thanks!

Btw, the simple devc example in the example folder does not run. Just as a note.

JanVogelsang commented 1 year ago

Fixed in 1.8.7

lu-kas commented 1 year ago

Thank you!