search

FireDynamics / fdsreader

Python reader for FDS data
GNU General Public License v3.0
44 stars 18 forks source link

side_surfaces seems messed up #59

Closed p-lauer closed 1 year ago

p-lauer commented 1 year ago

Hi!

First of all, thank you for this great tool. Since the &OBST ID implementation from issue #50 is not yet implemented in the official FDS release, I tried to filter data by the side_surfaces of the subobstructions, which would be sufficient for my application. It seems that fdsreader doesn't get the surface IDs correct.

In the fds input (test.txt), i´ve defined:

&OBST XB=0.2,1,1.0,1.4,0.2,0.4, SURF_ID='Burner'/
&OBST XB=0.0,3.6,0.0,2.4,0.0,.2, SURF_ID='ADIABATIC'/
&OBST XB=0.0,3.6,2.2,2.4,0.0,2.4, SURF_ID='ADIABATIC'/
&OBST XB=0.0,3.6,0.0,.2,0.0,2.4, SURF_ID='ADIABATIC'/
&OBST XB=0.0,0.2,0.0,2.4,0.0,2.4, SURF_ID='ADIABATIC'/

fdsreader gives me:

Obstruction(id=1, Bounding-Box=Extent([0.20, 1.00] x [1.00, 1.40] x [0.20, 0.40]), SubObstructions=1, Quantities=['temp'])
(Surface(name="INERT"), Surface(name="INERT"), Surface(name="INERT"), Surface(name="INERT"), Surface(name="INERT"), Surface(name="INERT"))

Obstruction(id=2, Bounding-Box=Extent([0.00, 3.60] x [0.00, 2.40] x [0.00, 0.20]), SubObstructions=1, Quantities=['temp'])
(Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"))

Obstruction(id=3, Bounding-Box=Extent([0.00, 3.60] x [2.20, 2.40] x [0.00, 2.40]), SubObstructions=1, Quantities=['temp'])
(Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"))

Obstruction(id=4, Bounding-Box=Extent([0.00, 3.60] x [0.00, 0.20] x [0.00, 2.40]), SubObstructions=1, Quantities=['temp'])
(Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"))

Obstruction(id=5, Bounding-Box=Extent([0.00, 0.20] x [0.00, 2.40] x [0.00, 2.40]), SubObstructions=1, Quantities=['temp'])
(Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"), Surface(name="Burner"))
JanVogelsang commented 1 year ago

True, this is a bug indeed. Fixed it in 1.9.9