FireDynamics / propti

PROPTI is an interface tool that couples simulation models with algorithms to solve the inverse problem of material parameter estimation in a modular way. It is designed with flexibility in mind and can communicate with arbitrary algorithm libraries and simulation models. Furthermore, it provides basic means of pre- and post-processing.
MIT License
15 stars 125 forks source link

Variable backup_every_rep not available to user #45

Closed p-lauer closed 6 years ago

p-lauer commented 6 years ago

In GitLab by @vinayak1 on Feb 23, 2018, 17:42

It has come to my notice that backup_every_rep is not available for user input during the set up of the backup properties. This implies that only the default value of 100 will be taken in every case. If this is relevant problem, we may want to consider adding this functionality to spotpy_wrapper.py.

p-lauer commented 6 years ago

In GitLab by @vinayak1 on Feb 23, 2018, 17:43

added ~276 label

p-lauer commented 6 years ago

In GitLab by @hehnen1 on May 3, 2018, 22:30

Hasn't this been added recently?

I think this issue could be closed since this seems to be the solution:

https://gitlab.version.fz-juelich.de/inverseproblemsinfiremodeling/propti/blob/master/propti/spotpy_wrapper.py#L177

p-lauer commented 6 years ago

In GitLab by @vinayak1 on May 9, 2018, 23:48

I was looking for where this issue was. It seems that somehow I related this to #32 and automatically closed the other one while fixing this issue :D

Luckily it seems that #32 also got fixed. So I'll close this one too !

p-lauer commented 6 years ago

In GitLab by @vinayak1 on May 9, 2018, 23:48

closed