search

FireDynamics / propti

PROPTI is an interface tool that couples simulation models with algorithms to solve the inverse problem of material parameter estimation in a modular way. It is designed with flexibility in mind and can communicate with arbitrary algorithm libraries and simulation models. Furthermore, it provides basic means of pre- and post-processing.
MIT License
15 stars 124 forks source link

Check `--clean_db` functionality, seems to count incorrectly #91

Closed TristanHehnen closed 3 years ago

TristanHehnen commented 3 years ago

The --clean_db function of the propti_analysis script seems to count the individuals from the SCE generations incorrectly. From 4 successfully completed runs only three appear in the scatter plots after the --clean_db call. Furthermore, the fitness boxplots show only two full generations, which seems to indicate that this functions counts incorrectly as well. Possibly the same countiong functionality is used in the background.

TristanHehnen commented 3 years ago

The counting of the generations should be working properly now: https://github.com/FireDynamics/propti/blob/220902b9b0e923d95eb474a611466b5697db06f8/propti_analyse.py#L1155 https://github.com/FireDynamics/propti/blob/220902b9b0e923d95eb474a611466b5697db06f8/propti/propti_monitor.py#L612

TristanHehnen commented 3 years ago

Seems to work as expected.