search

FireEmblemUniverse / ColorzCore

A rewriting of Core.exe for EA.
GNU General Public License v3.0
7 stars 7 forks source link

Refactor Simplify #28

Closed Crazycolorz5 closed 4 years ago

Crazycolorz5 commented 5 years ago

Addresses #26 (TODO: Test I didn't break anything), somewhat addresses #23. Just in general makes the code nicer and slightly tunes performance (I think).

Crazycolorz5 commented 4 years ago

Testing performance on building VBA:BT now.

Crazycolorz5 commented 4 years ago

Refacored version built VBA:BT in 42s, unrefactored in 48s. So I'd say it's a success. However, it did spit out an error that the old ver didn't, but maybe I was using the "wrong" old ver?

Edit: Both master branches assemble in the same time, and have the same error.

Crazycolorz5 commented 4 years ago

I think the algebraic effects nature of error handling is better suited for potential runtime errors. So I'm going to merge this branch once I fix all the potential errors.