Maybe fix lowercase code names on some systems

FireEmblemUniverse / ColorzCore

A rewriting of Core.exe for EA.

GNU General Public License v3.0

7 stars 7 forks source link

Maybe fix lowercase code names on some systems #43

Closed StanHash closed 5 years ago

StanHash commented 5 years ago

I got reports of lowercase code identifiers causing errors (while it shouldn't), but I couldn't reproduce the issue. I figured it may have been because of the culture-aware (whatever that means) nature of the string.ToUpper method that is used for converting code names, so I changed it to use ToUpperInvariant instead (which is apparently faster anyway).

The problematic case (poin vs POIN).

Crazycolorz5 commented 5 years ago

OK, I can see this potentially having some issues on some encodings. Not like we lose anything my merging this change.