search

FireEmblemUniverse / ColorzCore

A rewriting of Core.exe for EA.
GNU General Public License v3.0
7 stars 7 forks source link

Messages display full directory name. #44

Closed Crazycolorz5 closed 4 years ago

Crazycolorz5 commented 5 years ago

e.g. C:/Users/Name/Documents/Projects/MyProject/Event.event:12

This shouldn't be necessary in most cases, and the old MESSAGES: scheme didn't do so. I'm not entirely sure if full directory being displayed was by design, and even if it was, maybe remove it?

@StanHash

StanHash commented 5 years ago

Displaying a path to the file instead of only the filename was by design (The reason that pushed the change is that vscode's integrated terminal recognize the pattern and allow the user to click it for convenience, and I wouldn't be surprised if others do the same. But even without that, referring to files based on path other than on name is just better because less possibility for ambiguity). However, maybe displaying a relative path (to the wd? to the main file's dir?) instead of the absolute one would be better.

For messages caused by MESSAGE/WARNING/ERROR specifically, maybe allow the user to decide whether a location should be attached to the message or not (through a command line option)?

Crazycolorz5 commented 4 years ago

Closed unless anyone else cares about verbosity.