search

FireEmblemUniverse / SkillSystem_FE8

Creative Commons Zero v1.0 Universal
57 stars 93 forks source link

Skill Extensions not getting the icons #675

Closed cadebitterleaf closed 23 hours ago

cadebitterleaf commented 2 months ago

Screenshot (124) Screenshot (123) I keep getting an error when I try to open skill config in FeBuilder. I just installed the system. Did I install it incorrectly?

Veslyquix commented 2 months ago

Febuilder supports specific older builds of a slightly modified version of this buildfile. The latest patch says July 2022. Install skillsys via febuilder's Patches menu if you wish to edit the rom with febuilder.

I think feb expects skillsys data to be in a specific block of ROM, so things may only display if you have free space defined to build there. See the first lines of CustomDefinitions.event - using #define FreeSpace 0xb2a610 instead of 0xFE4000 might make feb display it.

cadebitterleaf commented 2 months ago

Unfortunately uncommenting #define FreeSpace 0xb2a610 did not work. However, thank you for the help. I'll just add it through the febuilder patch system.

ZeikoLeMonde commented 1 month ago

Adding to this, apparently using #define FreeSpace 0xb2a610 as Vesly suggested worked before #616.

Veslyquix commented 1 month ago

Febuilder searches for a sequence of bytes to find data. All it takes is a small change here to have febuilder unable to find something - it was not intended to be used to edit icons for skillsys master.

If you want febuilder support, install the 2022 patch, or edit how febuilder finds the table. Here's an example of how it finds NaturalCover for that patch: https://github.com/FEBuilderGBA/FEBuilderGBA/blob/af4234570e960d39747294c538e3cedbd751dee5/FEBuilderGBA/bin/Debug/config/patch2/FE8U/skill20220703/PATCH_NaturalCoverDamage.txt#L4