Mappings are not disabled when rebinding controls

FireFox2000000 / Moonscraper-Chart-Editor

BSD 3-Clause "New" or "Revised" License

225 stars 61 forks source link

Mappings are not disabled when rebinding controls #82

Closed TheNathannator closed 2 years ago

TheNathannator commented 2 years ago

Easiest example of this is toggling the metronome or clap while rebinding.

FireFox2000000 commented 2 years ago

Need to add a case for this under Services._IsTyping

TheNathannator commented 2 years ago

I'm having a difficult time understanding what exactly needs to be done. I tried doing the same thing that's done for the other component types, but that didn't work, so I'm not sure how to detect when the controls menu is open.

TheNathannator commented 2 years ago

Okay I got it figured out, was overthinking it a little.