.mid: Add support for note-based tap marker and `ENHANCED_OPENS` text event, fix some asserts being hit, write all 5 drum roll notes

[TheNathannator]

Summary:

• MidReader.ProcessNoteOnEventAsForcedTypePostDelay
  • Add message to assert
  • Add a couple comments for clarification
  • Add handling for setting note type to taps
  • Fix assert getting hit in cases where it's impossible for the note type to change:
  • Same-fret consecutive HOPOs, which are disallowed in MS but possible in chart files
  • Tap marking on open notes (they get turned into HOPOs instead where possible)
  • Use switch case on the type to be set instead of if-else chain
• Add process dictionary for ENHANCED_OPENS mode and switch to it when encountering that text event
• Write all 5 drum roll notes (120-124) instead of just the first (120)

Some more changes/fixes will be coming, wanted to split the PRs into smaller chunks where possible.

[FireFox2000000]

Only if it's stuff added in this PR. If there's stuff already in master then I'm not fussed if that gets fixed up or not.

On Tue., 29 Nov. 2022, 8:04 am Nathan, @.***> wrote:

@.**** commented on this pull request.

In Moonscraper Chart Editor/Assets/Scripts/Game/Charts/IO/Midi/MidIOHelper.cs https://github.com/FireFox2000000/Moonscraper-Chart-Editor/pull/89#discussion_r1034046930 :

@@ -26,6 +26,7 @@ public static class MidIOHelper // Note numbers public const byte DOUBLE_KICK_NOTE = 95; public const byte SOLO_NOTE = 103; // http://docs.c3universe.com/rbndocs/index.php?title=Guitar_and_Bass_Authoring#Solo_Sections

• public const byte TAP_NOTE = 104; // https://strikeline.myjetbrains.com/youtrack/issue/CH-390

My only problem with renaming the constant is that none of the other non-RB stuff does this, would you want me to change that?

— Reply to this email directly, view it on GitHub https://github.com/FireFox2000000/Moonscraper-Chart-Editor/pull/89#discussion_r1034046930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEMD3BCABK7O42MWZJSC6DWKUM6JANCNFSM6AAAAAASM6EAF4 . You are receiving this because you commented.Message ID: @.*** com>