search

FireFox2000000 / Moonscraper-Chart-Editor

BSD 3-Clause "New" or "Revised" License
225 stars 61 forks source link

.mid: Rewrite SysEx event parsing/writing to properly use the specs defined by Phase Shift #93

Closed TheNathannator closed 1 year ago

FireFox2000000 commented 1 year ago

Does RockBand uses SysEx events at all? Could seem a bit confusing to be labelling all this as PS when it's handling other game types as well.

TheNathannator commented 1 year ago

Rock Band doesn't use any SysEx events. The Phase Shift team created the ones that charts use, hence the naming.

FireFox2000000 commented 1 year ago

Rock Band doesn't use any SysEx events. The Phase Shift team created the ones that charts use, hence the naming.

Cool, just wanted to confirm that.

FireFox2000000 commented 1 year ago

Needs merge conflicts fixed.

TheNathannator commented 1 year ago

Figured there would be some, got those fixed up. I should probably test again to double-check that it's all working after this though.

TheNathannator commented 1 year ago

And this is exactly why you test changes. image What I had before should really trigger a warning lol image

TheNathannator commented 1 year ago

Alright, looks like it's working correctly again. That should be all, then.