FireMario211 / Prism-Menu

A mod menu made in Geode for Geometry Dash
GNU General Public License v3.0
47 stars 25 forks source link

Not Saving a Certain Setting [Bug]: #136

Open nbieberitz opened 3 months ago

nbieberitz commented 3 months ago

Platform

Android 64

Version

v1.8.2

Describe the bug

Under the "Creator" tab in the prism menu, There are three settings: Verify Hack, Copy Hack, and Custom Object Bypass. The Verify and Copy Hack seem to save the setting. (If I have the setting on, it stays on, even if I re-reboot Geode.) However, Custom Object Bypass doesn't seem to save its setting. Every time I reboot Geode, it turns off, and I have to turn it on again.

Expected Behavior

I would like the Custom Object Bypass setting to keep on, if I had it on previously, and vice versa, such as the Verify and Copy Hack work.

How to reproduce

  1. Open Geode.
  2. Open the Prism Menu.
  3. Go to the Creator tab.
  4. The Custom Object Bypass should be off. Turn it on.
  5. Close Geode, and repeat steps 1, 2, and 3.
  6. As you can see, the Custom Object Bypass should have turned itself off.

Mods Installed

Advanced Song Preview, Animated Fire, Art Importer, Attempt Utilities, Auto Nong, AutoSong, Backups, Badges API, Better Progression, BetterEdit, BetterInfo, Chest Alert, Circle Tool, Copy Song ID, Custom Keybinds, Custom Profile Image, Death Tracker, DeathLink, Editor Level ID API, GDUtils, GMD API, Geometry Dash, Globed, Happy Textures :3, Jukebox, Level History, Level Info, Level Info in Pause Menu, Level Size, Level Thumbnails, Misc Bugfixes, More Object Info, Newgrounds Explorer, Node IDs, Practice Attempts, Prism Menu, QOLMod (currently disabled though), Run Info, Scroll Zoom, Shopping List, Shortcuts Menu, SongPreview, Trashcan, and Treasure Checklist. 

Crash Logs

No response

Additional Context

Phone: Galaxy S23 Ultra One of the reasons I added what phone I use is to show that it's not that my phone acting up. It's something else...

FireMario211 commented 3 months ago

This is not a bug. The reason why it doesn't save is because it's a hack that does a "patch". As explained in the README: https://github.com/FireMario211/Prism-Menu/blob/main/resources/hacks/README.md

Note that creating patches will disable saving the setting, meaning the user would have to enable it again. This is because Prism Menu currently does not have a check to see if hacks are enabled when Geometry Dash is launched, and to apply the patches.

It explains that patches do not enable saving.

In the future however, this will be added.

nbieberitz commented 3 months ago

Ok, thanks for replying so fast.