FireMario211 / Prism-Menu

A mod menu made in Geode for Geometry Dash
GNU General Public License v3.0
33 stars 14 forks source link

[Bug?]: Changing the type of a previously saved hack value crashes game on startup #62

Open glistermelon opened 4 months ago

glistermelon commented 4 months ago

Platform

Windows

Version

live build (as of 2/24 7pm)

Describe the bug

iffy about calling this a bug, but in the (unlikely) event that any hack's stored value type is changed, the game will crash every time you start it unless you manually remove the old value from the save file.

won't be an actual problem unless such a change actually happens though, but it's not impossible

Expected Behavior

the game shouldn't crash, and the invalid saved value should probably be erased

How to reproduce

again iffy about calling this a bug because you'll never encounter this unless you're actually developing hacks but

Mods Installed

devtools and prism menu

Crash Logs

crash occurs in the JSON parser, in any of the as_[type] functions

Additional Context

No response

FireMario211 commented 4 months ago

There isn't really any functionality of "transitioning" hack types over, as I never intended to switch hack types. I could implement a check where it checks if the type is invalid, and if it is, reset to default value, although this is very unlikely to happen unless someone or I wants to change the hack type to something else.

glistermelon commented 4 months ago

Yeah. Honestly there's no point in worrying about it unless it actually becomes a problem, especially since no end user will actually encounter it.