FireRadical22 / pe

0 stars 0 forks source link

Commands allow more than 1 of the same field to be passed through #1

Open FireRadical22 opened 1 year ago

FireRadical22 commented 1 year ago

All commands that require a field with a prefix (n/name, p/phone number, a/address, eid/id etc., excluding t/tags) allows more than 1 of the same field to be passed through.

For instance, executing adep n/Hello n/Engineering was acceptable where based on UG, adep should only be taking in one n/ field.

Allowing more than 2 of the same field in command.PNG

Another example is feid eid/1 eid/2, where based on UG, feid should only be taking in one eid/ field.

Allows more than 2 eid fields to be accepted.PNG

soc-pe-bot commented 1 year ago

Team's Response

Hi, we see the point you are making but we have decided to handle such rare instances by only accepting the last field. We have explicitly stated our design decision in section 3.3 of our UG.

Screenshot 2023-04-15 at 3.17.37 AM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]