FireRadical22 / pe

0 stars 0 forks source link

Allows invalid phone numbers (Numbers not starting with 6,8 or 9) #5

Open FireRadical22 opened 1 year ago

FireRadical22 commented 1 year ago

Given that the p/ field accepts 8 digits, its safe to assume this is accepting Singapore numbers. Hence, p/ should only accept phone numbers starting with 6, 8 or 9. However, I find that it can accept numbers starting with 1,2,3 etc.

Format Bug Pt3.PNG

soc-se-bot commented 1 year ago

Team's Response

This isn't a functionality bug because it is explicitly stated in the UG that numbers with 8 digits are accepted as a phone number field.

Understandably, it can be argued that phone number field should only accept numbers preceding with 8 or 9. But as of now, verifying the validity of a phone number is not a value-proposition of our app, at least not in this iteration. In fact, given that our app is for HR personnel to track employees who can be possibly from abroad, subsequent iterations, when dealing with validity of phone numbers, would have to account for flexibility of country codes and varying-length phone numbers. The validity checks for these is far from trivial and hence possibly reserved for subsequent iterations.

This issue is actually highlighted in section 8.3 of our Planned Enhancements in the DG as well.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]