[BUG] Github Action Logs Look Corrupted

[Aedalus]

Action config

Created a brand new Github workflow via the firebase CLI. No modifications were made to the workflow, and the firebase project has worked fine before setting up CI/CD.

    steps:
      - uses: actions/checkout@v2
      - run: npm ci && npm run build
      - uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          repoToken: '${{ secrets.GITHUB_TOKEN }}'
          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_MY_PROJECT}}'
          channelId: live
          projectId: <my-project>

Error message

During the deploy step, logs look like some form of encoding/coloring got messed up. Logs also increased to over 750MB total, slowing the github UI to a crawl. This recent issue seems to point towards recent issues with a 'Faker' package being the cause, but it's not clear to me if that is the case. Would prefer if we could leave a bug report open to help track the issue, and allow others to find some information if seeing similar problems.

[sagearora]

Same issue on my deploys starting today!

[khromov]

Same issue here on existing app that has been deploying without problems for several weeks.

[regulait-dev]

Same problem starting today

[Andrew-Hopkins-Liqua]

I am having the same issue. This is a game-breaking bug.

I believe this issue is related to the Marak Zalgo Liberty 2 bug. https://snyk.io/blog/open-source-maintainer-pulls-the-plug-on-npm-packages-colors-and-faker-now-what/ https://github.com/Marak/colors.js/issues/285

[elsowiny]

I am having the same issue. This is a game-breaking bug.

I believe this issue is related to the Marak Zalgo Liberty 2 bug. https://snyk.io/blog/open-source-maintainer-pulls-the-plug-on-npm-packages-colors-and-faker-now-what/ Marak/colors.js#285

yes I think it has to do with this

[joshkautz]

Having this issue too. Yikes!

[Andrew-Hopkins-Liqua]

@jhuleatt Is there anything we can do to avoid the colors library and fastpace this issue until Marak finishes his protest? I believe this is the dependency tree that is causing this issue

• Action-hosting-deploy
  • Firebase-tools
    • cli-table
      • colors (subdependancy which is causing the issue)
    • winston
      • logform
        • colors (subdependancy which is causing the issue)

[Andrew-Hopkins-Liqua]

update: winstonJS, and logformJS have pinned the colors package to 1.4.0 to avoid the security vulnerability.

My GitHub actions are now working again (albeit with a lot of depreciation warnings)

[anthonyjdella]

Just replying because I'm also having the same issue. It is causing my deploy to fail 😢

Edit: It works now, as of 8:20PM CST. Thanks Andrew!

[Andrew-Hopkins-Liqua]

It works now, as of 8:20PM CST. Thanks Andrew!

I'm happy to be a messenger of good news! but just to be clear: I'm not a maintainer of any of these repo's . just a fellow dev who was impacted by the Liberty 2 issue

[elsowiny]

update: winstonJS, and logformJS have pinned the colors package to 1.4.0 to avoid the security vulnerability.

My GitHub actions are now working again (albeit with a lot of depreciation warnings)

thank you for the updates!

[jhuleatt]

Thanks for the helpful information @Andrew-Hopkins-Liqua. To tie things together, here's the bug in the Firebase CLI repo: https://github.com/firebase/firebase-tools/issues/3999

[sfxoodeyemi]

I'm experiencing this in my nestjs app. I get this on the aws build console.

[jhuleatt]

This was fixed in the Firebase CLI in https://github.com/firebase/firebase-tools/pull/4004