search

FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

Enables deployment of functions to firebase #190

Open m5kr1pka opened 2 years ago

m5kr1pka commented 2 years ago

Changes enables deployment of functions to firebase via channelId flag.

Requirements:

IAM Roles changes needed for firebase service account:

and update in firebase.json predeploy script:

"predeploy": [
   "npm --prefix \"$RESOURCE_DIR\" install",
]

Related issues:

54

m5kr1pka commented 2 years ago

Accepted Google's CLA, try to rescan.

m5kr1pka commented 2 years ago

PR needs appropriate changes in documentation that I can make, if approved.

m5kr1pka commented 2 years ago

Any feedback?

dawidcyron commented 1 year ago

@m5kr1pka big thanks for the solution! I was struggling for half a day trying to figure out why my actions were failing while trying to deploy Cloud Functions.

m5kr1pka commented 1 year ago

It's probably due to permissions, flags or services needs to be enabled. I had a problem a similar problem, for the first time in project I deployed from local machine using firebase tools for GCloud services be enabled, don't remember which service was a problem at the time.

aalcott14 commented 1 year ago

Are there any plans on merging this?

jakehockey10 commented 8 months ago

@m5kr1pka Have you heard anything on merging this from the team? Thanks for contributing this! Looking forward to working with it!

m5kr1pka commented 8 months ago

@m5kr1pka Have you heard anything on merging this from the team? Thanks for contributing this! Looking forward to working with it!

Unfortunately not. Try using my version. Maybe the issue is that first deployment - you have to push to firebase manually with firebase-cli for all the on gcloud flags to be set/opened.