FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
704 stars 202 forks source link

feat: add configFileName option #196

Open markwhitfeld opened 2 years ago

markwhitfeld commented 2 years ago

For projects that use multiple firebase.json files, it is essential to be able to specify the name of the file that the cli should use. This is available as the --config option in the firebase CLI. This PR adds a configFileName action option to set this parameter.

I opted for the configFileName option name over config to avoid any ambiguity that it should be a file name.

markwhitfeld commented 2 years ago

@jamesdaniels and @jhuleatt I wanted to make a few details explicit about the decisions I made in this PR...

I could have gone either way on the name of the option. There was a choice of:

I settled on the configFileName option name.

tayzlor commented 2 years ago

πŸ‘ for this. We're deploying to firebase in a Monorepo with NX (and multiple firebase apps). This functionality would be hugely valuable. Seems like there is an (older) overlapping PR for this over here too https://github.com/FirebaseExtended/action-hosting-deploy/pull/153

algoflows commented 2 years ago

πŸ‘πŸ» as well @jhuleatt this has been open for ages, any chance of a review merge?!

markwhitfeld commented 1 year ago

@jhuleatt I have resolved the merge conflicts. The PR is ready for review again πŸ‘

markwhitfeld commented 1 year ago

Not wanting to nag, but who is overseeing this repo and can give some sort of response to this PR? I am an Open Source author myself and I understand that things get busy. Some sort of indication would be helpful though.