Open markwhitfeld opened 2 years ago
@jamesdaniels and @jhuleatt I wanted to make a few details explicit about the decisions I made in this PR...
I could have gone either way on the name of the option. There was a choice of:
config
: matches the argument that is passed to the firebase cli, but might be a bit ambiguous as to what config it is referring to in the context of a github actionfirebaseConfigJsonFileName
is just a bit muchπ ! configFileName
: is clear that it is referring to a file name where the firebase config is held.
entryPoint
setup incorrect if you refer to any subpath. The firebase cli uses the config
option to determine the project root and therefore would conflict with the expectations of the entryPoint
option that was set for this action.I settled on the configFileName
option name.
π for this. We're deploying to firebase in a Monorepo with NX (and multiple firebase apps). This functionality would be hugely valuable. Seems like there is an (older) overlapping PR for this over here too https://github.com/FirebaseExtended/action-hosting-deploy/pull/153
ππ» as well @jhuleatt this has been open for ages, any chance of a review merge?!
@jhuleatt I have resolved the merge conflicts. The PR is ready for review again π
Not wanting to nag, but who is overseeing this repo and can give some sort of response to this PR? I am an Open Source author myself and I understand that things get busy. Some sort of indication would be helpful though.
For projects that use multiple
firebase.json
files, it is essential to be able to specify the name of the file that the cli should use. This is available as the--config
option in the firebase CLI. This PR adds aconfigFileName
action option to set this parameter.I opted for the
configFileName
option name overconfig
to avoid any ambiguity that it should be a file name.