FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

[BUG] action-hosting-deploy fails with Node v12 #204

Closed nappernick closed 1 year ago

nappernick commented 2 years ago

Action config

Error message

/opt/hostedtoolcache/node/12.22.12/x64/bin/npx firebase-tools hosting:channel:deploy pr2057-pricing_breakdown_si --only cms --expires 7d --project guesthouse-cms-dev --json

Firebase CLI v11.0.0 is incompatible with Node.js v12.22.12 Please upgrade Node.js to version >= 14.18.0

The process '/opt/hostedtoolcache/node/12.22.12/x64/bin/npx' failed with exit code 1

Expected behavior

Preview builds with Node v12.22

Actual behavior

Channel preview build fails due to the use of the newest version of firebase-tools, which dropped support for v12. Would love the ability to specify which version of firebase-tools the action uses while we migrate to v16.

kou65536 commented 2 years ago

:+1: My team also faced this problem and manually deployed as workaround.

ustun commented 2 years ago

@nappernick Can you install node 14 or later, just before the actions deploy action runs?

sergeimelnik1980 commented 2 years ago

Yes, we also faced deployment problem on 12 version :(

angelcervera commented 2 years ago

The problem is because it is installing the last version of firebase and support for nodejs 12 has been dropped. Is there a way to specify the firebase cli version to use? Using version 10.9.2 will fix the problem. Moving to nodejs 14 is not so easy.

ustun commented 2 years ago

This action is not official, but one would expect a little bit more support from Firebase team. As it is, the repo seems to be abandoned and as such we have forked it internally.

bkendall commented 1 year ago

The version of firebase-tools can now be specified, if you need to stick on an older version.