search

FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

details_url not outputting for production deploys #213

Open intelseb opened 2 years ago

intelseb commented 2 years ago

The use case you're trying to solve

Production deploy doesn't set details_url output, but prints it in the action when run

Change to the action that would solve that use case

ensure that for production deployment code the following is set as say line 101 in file https://github.com/FirebaseExtended/action-hosting-deploy/blob/0f248036885ae672f78587669fa2923f0ef6cac2/src/index.ts

setOutput("details_url",url);

Other considerations

Although the url for production is known and static, for the purposes of using a github action, if the wiki says the output is available it should be, the Readme at https://github.com/FirebaseExtended/action-hosting-deploy#outputs should also be updated to reflect the following

urls The url(s) deployed to (preview channels only)

expire_time The time the deployed preview urls expire (preview channels only)

details_url A single URL that was deployed to (production & preview)

lopes-gustavo commented 1 year ago

I opened a PR to fix this https://github.com/FirebaseExtended/action-hosting-deploy/pull/302

pm0u commented 4 months ago

So there is no way to get the deployed to URL for a production deploy? 😵