search

FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
704 stars 202 forks source link

Update `DeploySuccessComment` with target #222

Open KKimj opened 2 years ago

KKimj commented 2 years ago

Hello!

Please check purpose here (#221)

Procedure which I conducted,

  1. Update interpretChannelDeployResult
  2. Update DeploySuccessComment with Procedure 1
  3. Update test codes and test with npm run test
  4. Build with npm run build

Please review, Thanks.

elikohen commented 2 years ago

I'd love to push for this to be reviewed :) I'm also in need for this code

KKimj commented 2 years ago

@jhuleatt Hello! Would you leave some comments this PR please? Thanks!