search

FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

Ability to deploy functions along side hosting - usefull for SSR apps #230

Closed itsmasabdi closed 1 year ago

itsmasabdi commented 2 years ago

Hi team,

I made a few changes to be able to deploy functions along with the hosting. But for some reason, I get this error when trying to deploy my firebase app

*** "status": "error", "error": "Missing permissions required for functions deploy. You must have permission \u001b[1miam.serviceAccounts.ActAs\u001b[22m on service account \u001b[1mmy-project@appspot.gserviceaccount.com\u001b[22m.\n\nTo address this error, ask a project Owner to assign your account the \"Service Account User\" role from this URL:\n\nhttps://console.cloud.google.com/iam-admin/iam?project=my-project" ***

The service account has Service Account User role and the deployemnt works when I use the official github action repo FirebaseExtended/action-hosting-deploy@v0

Would you be able to point me to how to fix this?

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jamesdaniels commented 1 year ago

The action is now capable of deploying Cloud Function rewrites using pinTag: true and using the deploy from source functionality for web frameworks