FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

[BUG] Cannot Find Module "is-npm" #235

Closed brian-cresicor closed 1 year ago

brian-cresicor commented 1 year ago

Action config

Error message

image

Expected behavior

Deployment completes successfully.

Actual behavior

Deployment fails due to missing module is-npm in firebase-tools.

vigneshwaran-vtpl commented 1 year ago

+1

UgniusSmidtas commented 1 year ago

Same here :/

emrahyumuk commented 1 year ago

+1

ocruzv commented 1 year ago

This error comes from the firebase/firebase-tools dependency. I think that will be solved on a future update on their end https://github.com/firebase/firebase-tools/issues/5010

emrahyumuk commented 1 year ago

This error comes from the firebase/firebase-tools dependency. I think that will be solved on a future update on their end firebase/firebase-tools#5010

There is no problem with firebase-tools on local. I just get this error on github action. the action make deployment successfully but get this error.

aliak00 commented 1 year ago

Same here. How could this start happening with no code changes or dep changes? Is there some funny config somewhere? I can see is-npm in my package lock file. - we are on firebase-tools version 10.7.0. Updating that didn't help.

Maria-Lurdes commented 1 year ago

I have the same issue, updated everything in my project but it didn't help

bkendall commented 1 year ago

Thanks for reporting. We've got a couple people looking into this trying to figure out what happened. So far as we can tell, locally deploying should work fine and it's just the GH action that's broken (which is only more confusing).

aliak00 commented 1 year ago

FYI @bkendall : Changed github action to use node 16 instead of 14 and it all good 🤷

image
gorden0929 commented 1 year ago

+1

elmehdibm commented 1 year ago

Same here

Jerkovic commented 1 year ago

+1

dexterastin commented 1 year ago

+1

igorgottschalg commented 1 year ago

+1

olbapd commented 1 year ago

+1

bkendall commented 1 year ago

Alright, we've at least made a little patch in the code we think is triggering the error to catch it and be a little more quiet if this happens. We're still digging into why this is happening, but planning on releasing tomorrow morning with that patch.

bkendall commented 1 year ago

This is the patch we made, fwiw: firebase/firebase-tools#5010

dawogfather commented 1 year ago

+1 👍🏽

AntiraLoachote commented 1 year ago

+1

dcroote commented 1 year ago

Working now, thanks!

victorwvieira commented 1 year ago

It's working now, thank you!