search

FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
704 stars 202 forks source link

Is it possible to enable support for web frameworks? #239

Closed thecannabisapp closed 2 years ago

thecannabisapp commented 2 years ago

The use case you're trying to solve

I'm trying to use GitHub actions to deploy my nextjs SSR app to firebase hosting. I understand in order to deploy a SSR app, I need to enable webframeworks with firebase experiments:enable webframeworks command.

Change to the action that would solve that use case

Is this possible by adding a run: after uses: in the yml file?

- uses: FirebaseExtended/action-hosting-deploy@v0
        run: firebase experiments:enable webframeworks
        with:
          repoToken: "${{ secrets.GITHUB_TOKEN }}"
          firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_THECANNABISAPP_V2_DEV }}"
          channelId: live
thecannabisapp commented 2 years ago

NVM, I think I found a way to do this.

I added a line above the action to install firebase and enabled web framework support.

- name: Install firebase and npm packages
   run: install -g firebase-tools && firebase experiments:enable webframeworks
- uses: FirebaseExtended/action-hosting-deploy@v0
...