FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
704 stars 202 forks source link

[BUG] Service account creation doc incomplete #240

Closed kribor closed 2 years ago

kribor commented 2 years ago

Action config

- uses: FirebaseExtended/action-hosting-deploy@v0
  with:
    repoToken: "${{ secrets.GITHUB_TOKEN }}"
    firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT }}"
    expires: 30d
    projectId: my-awesome-project

Error message

Relevant part of deployment error: Error: HTTP Error: 403, Permission 'cloudfunctions.functions.list' denied on 'projects/natural-cycles/locations/-/functions'

Expected behavior

Successful deployment

Actual behavior

Failed deployment

Proposed solution

Add another role to documentation: https://github.com/FirebaseExtended/action-hosting-deploy/blob/main/docs/service-account.md that includes cloudfunctions.functions.list. Adding Firebase Develop Admin works but may not be "minimal required"

aaronadamsCA commented 2 years ago

Our long-standing uses of this action suddenly started failing in the last 2 days with this same error message, so I get the feeling this is the result of a change, inadvertent or not.

We don't have any functions, so I'm not sure why our deploy process would need permission to list functions.

aaronadamsCA commented 2 years ago

Yep, it's a bug introduced in an upstream release 6 hours ago: https://github.com/firebase/firebase-tools/issues/5071

ihor-panasiuk95 commented 2 years ago

Same for us :( We also have troubles during deployment caused exactly the same error.

AurelienLoyer commented 2 years ago

Same issue on my side 😕

Screen Shot 2022-10-06 at 5 50 49 PM
AurelienLoyer commented 2 years ago

Looking comments on other issues ( #203 ) i created my own action, forking this one, and pining the firebase-tools version to previous one ( 11.13.0 )

You can find my solution here https://github.com/AurelienLoyer/action-hosting-deploy/commit/fbc5bbeb83621c290d5cbb21650ffb25386979d4

And i replace this in my projet

image
aaronadamsCA commented 2 years ago

This has been fixed upstream. I believe this issue can be closed now.