FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

Pin version of firebase-tools used for deploys. #242

Closed mikelehen closed 1 year ago

mikelehen commented 1 year ago

The use case you're trying to solve

Github deploys work reliably from day to day.

Change to the action that would solve that use case

Instead of installing the latest firebese-tools every time, pin to a version that is known to work correctly and only update it periodically. Perhaps allow developers to override the version if they choose.

Other considerations

For context, the firebase-tools@11.14.0 release had a regression that broke deploys for many firebase projects. https://github.com/firebase/firebase-tools/issues/5071

I don't need my automatic deploys to be using the absolute latest version of firebase-tools. I'd rather it only update occasionally so that I'm not subject to surprise breakages.

davideast commented 1 year ago

Hey @mikelehen! I think adding a version override is more than a reasonable option for starters. I'll look into some options for improvement here and get back to you.

aaronadamsCA commented 1 year ago

+1 to pinning the dependency. I know it would require an action release every time the internal version was to be updated; but this would be correct, and would mirror the way other GitHub Actions generally work.

drummerjolev commented 1 year ago

+1, great idea @mikelehen

mikelehen commented 1 year ago

Awesome, thanks @davideast!

jhuleatt commented 1 year ago

Thanks for the feedback all! firebaseToolsVersion is now available as an option thanks to #246. For now, we're going to keep @latest as the default behavior.