search

FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

Upgrade current action to use node 16 instead of 12 #244

Closed soleo closed 4 months ago

soleo commented 1 year ago

The use case you're trying to solve

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, FirebaseExtended/action-hosting-deploy, actions/checkout

Change to the action that would solve that use case

Other considerations

soleo commented 1 year ago

https://github.com/FirebaseExtended/action-hosting-deploy/pull/245/files for the changes

oyvindwe commented 7 months ago

This issue seems to be fixed (partially) by PR #246, but now v16 is deprecated, and actions must be updated to use node v20 per https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

jhuleatt commented 4 months ago

Fixed by #344 https://github.com/FirebaseExtended/action-hosting-deploy/pull/344