Closed soleo closed 4 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
This looks very reasonable. Would you mind catching it up with main
and updating the branch? Thanks!
Sure, @bkendall . I just rebased it with the main branch. If you wanna see a working demo, you could also check out https://github.com/soleo/xinjiangshao.com/blob/master/.github/workflows/firebase-hosting-pull-request.yml for reference
oh this nonsense. The tests that require secrets are going to fail because they won't work from a fork. I'll take care of that once you remove the tsconfig thing :)
Oops - sorry about "Approving" the PR. That was a mistake, please dismiss the review. Thank you
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
GitHub is sunseting nodeJS 12 for actions.
Similar approach like https://github.com/actions/checkout/pull/689/files