FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

[BUG] Successful action reporting as failed due to GitHub 'set-output' deprecation warning #247

Closed moealien closed 1 year ago

moealien commented 1 year ago

Action config

- uses: FirebaseExtended/action-hosting-deploy@v0
  with:
    repoToken: "${{ secrets.GITHUB_TOKEN }}"
    firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT }}"
    expires: 30d
    projectId: any-project-id

Error message

Warning in run output

2022-10-13_23 04 16

Action is shown as failed despite deployment succeeding

2022-10-13_23 14 11

Expected behavior

Action runs and deploys normally.

Actual behavior

Action runs normally. GitHub deprecation warning causes the action to appear to have failed, despite the deployment working as intended, and changes being reflected on the deploy target.

More info

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

cgutierr-zgz commented 1 year ago

I'm suggest to reopen this since me and some other friends are getting this deprecated error warning in our projects

SarvagyaVaish commented 1 year ago

I have been getting these warnings as well.

nilsreichardt commented 1 year ago

@jhuleatt It's only a few weeks until 1st June 2023. The current version of action-hosting-deploy wouldn't work anymore. Is there any chance you or someone in your team could fix this issue / review the open pull requests, like: #261?

JaffaKetchup commented 1 year ago

Hey @jhuleatt, The deadline to resolve this is in about 2 weeks! Really is high priority now.

JaffaKetchup commented 1 year ago

This has been resolved by the merging of #279 I think.

jhuleatt commented 1 year ago

This has been fixed, thanks all