Closed f0urfingeredfish closed 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I'm getting the CLA sorted. Unless you want me to close this and just upgrade on your end?
@f0urfingeredfish any luck on the CLA Nick? 😟
@NKalganov I have had no luck. I have signed the CLA and so had my company and when I go to have it check again Google gives me a 400 error on this PR CLA check
Re-opening to see if CLA check gets triggered again
Closing in favor of this PR https://github.com/FirebaseExtended/action-hosting-deploy/pull/279 which includes the same fix and the author has a working CLA check.
I also discovered that you can't just upgrade the @actions/core
package you also need to upgrade microbundle
because there is a bug in microbundle (parcel) that doesn't bundle the crypto package correctly and you will get this error Error: crypto.getRandomValues() not supported. See https://github.com/uuidjs/uuid#getrandomvalues-not-supported
when running the workflow.
fixes https://github.com/FirebaseExtended/action-hosting-deploy/issues/247
This updates the "@actions/core" package to fix the deprecated setOutput warning per Github's instructions.
This warning appears as an annotation when run:
Important info on deprecation dates from Github:
NOTE: June 1st, 2023 is when this action will start failing with an error unless fixed.