Possibility to Deploy SSR (Next.js) app with github action

[alekseykarpenko]

The use case you're trying to solve

I have my GitHub action config generated alongside with setting up webframeworks support for SSR app (Next.js). When I deploy the app manually it all works as expected, but when using FirebaseExtended/action-hosting-deploy it leads to getting 404 for all dynamic pages (while static content works fine).

A quick search on this topic showed up that this GitHub action doesn't yet support deploying of Cloud Functions, that's why all the dynamic part of the app is being constantly lost during deployment. But since everything is being deployed correctly, seems Previews already support dynamic content through Cloud Functions.

Change to the action that would solve that use case

There is already a potential fix for this in opened PRs: https://github.com/FirebaseExtended/action-hosting-deploy/pull/190

[steebchen]

This would be so great to have!

[dannydeut]

I got this to work by adding the environment variable FIREBASE_CLI_EXPERIMENTS which is part of firebase-tools.

- name: Deploy to Firebase
  uses: FirebaseExtended/action-hosting-deploy@v0
  with:
    repoToken: '${{ secrets.GITHUB_TOKEN }}'
    firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
    channelId: live
    projectId: ...
  env:
    FIREBASE_CLI_EXPERIMENTS: webframeworks

[steebchen]

@dannydeut Yeah, this fixes the issue when using a standalone Next app without any functions (or SSR as that uses functions), which is why this issue is still relevant. But thanks for the comment, as it's maybe helpful for other people running into this without using functions!

[robokozo]

I'm doing deployments with https://nitro.unjs.io/deploy/providers/firebase and it'd be cool to have this integration support it too

[art-ash]

Really hope this enhancement will be implemented. We switched from hosting on Vercel to Firebase, and inability to deploy via GitHub Actions, makes me feel that this decision was premature

[steebchen]

Just for everyone's information, it works with the latest firebase CLI with two manual changes:

1) add additional permissions manually to the firebase service account which the CLI creates:

• Cloud Functions Admin
• Cloud Deploy Service Agent
• Secret Manager Viewer
• Service Account User (edited as mentioned by @art-ash)

2) set an env var in the action (FIREBASE_CLI_EXPERIMENTS: webframeworks,pintags)

Obviously, it would be great to make this work fully automatically and ideally also have a test case for it, but the manual workaround doea the trick for now.

[art-ash]

@steebchen apart from mentioned, in my case, I also needed to grant the created by CLI "github-action-service-account" with "Service Account User" role (roles/iam.serviceAccountUser). The action always failed without it. Maybe that's because I started configuring this workflow without Admin role (not sure, I'm new to GCP)

[knownasilya]

Can you deploy functions with this? Not NEXT specific that is.

[jrnkng]

Its works for me expect the images do not show up (can't find any). But when I deploy via the firebase CLI images do work. Anyone knows why? /