FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

Updated dependencies to fix set-output warning #279

Closed yurist38 closed 1 year ago

yurist38 commented 1 year ago

Hello,

I've noticed this warning in my CI output, and I'm pretty confident it's coming from this action. This PR is an attempt to fix it, but I didn't test it myself yet. I've simply upgraded all dependencies and fixed a couple of small things in the GitHub CLI in order to make it work again.

Screenshot 2023-04-22 at 16 18 40

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

f0urfingeredfish commented 1 year ago

@jhuleatt could we get some traction on this please? This action seems really popular and it will stop working on June 1st, 2023 unless fixed.

NKalganov commented 1 year ago

@jhuleatt could you please merge this branch? We have only two weeks left before the main branch becomes outdated without this update. Thank you in advance! 🙏

jhuleatt commented 1 year ago

Thank you @yurist38! Really appreciate this!

yurist38 commented 1 year ago

Awesome! Thank you for reviewing and merging this!