FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

[BUG] GitHub comment not appearing #294

Open kasvith opened 1 year ago

kasvith commented 1 year ago

Action config

      - uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          repoToken: '${{ secrets.GITHUB_TOKEN }}'
          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
          channelId: preview
          projectId: appname

Error message

No Errors

Expected behavior

GithHub comment to be appear in PR

Actual behavior

No comments appearing in PR. But we get the deploy URL in the deploy log

seth-acuitymd commented 10 months ago

I think I'm running into the same issue - are you seeing

Deploying to Firebase Preview Channel <channel name> 
Commenting on PR

in your build logs, or just the Deploying... line?

Can I ask what your trigger is for your GitHub Action? (push to branch, PR created, etc etc)

mpuxted commented 7 months ago

I thought I had the same issue, but then I realised that it will only comment once, meaning even if you deploy again it won't add a new comment. This could be made clearer in the docs