search

FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
704 stars 202 forks source link

[BUG] Cannot find module 'vite' #329

Open dolanmiu opened 10 months ago

dolanmiu commented 10 months ago

When I add webframeworks in an Angular 17 deployment with SSR, FirebaseExtended/action-hosting-deploy requires vite to be installed. It works fine deploying locally, but fails on GitHub Actions.

Action config

Error message

/opt/hostedtoolcache/node/18.19.0/x[64](https://github.com/dolanmiu/Fluid-Paper/actions/runs/7282742720/job/19845642204#step:6:67)/bin/npx firebase-tools@latest deploy --only hosting:fluid-paper-front --project fluid-paper --json
  npm WARN exec The following package was not found and will be installed: firebase-tools@13.0.2
  Could not load dependency vite in ./spa, have you run `npm install`?
  ***
    "status": "error",
    "error": "Cannot find module 'vite'\nRequire stack:\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/frameworks/utils.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/frameworks/index.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/controller.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/commandUtils.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/database-get.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/index.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/index.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/bin/firebase.js"
  ***
    "status": "error",
    "error": "Cannot find module 'vite'\nRequire stack:\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/frameworks/utils.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/frameworks/index.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/controller.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/commandUtils.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/database-get.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/index.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/index.js\n- /home/runner/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/bin/firebase.js"
  ***
  The process '/opt/hostedtoolcache/node/18.19.0/x64/bin/npx' failed with exit code 2
  Retrying deploy with the --debug flag for better error output
  /opt/hostedtoolcache/node/18.19.0/x64/bin/npx firebase-tools@latest deploy --only hosting:fluid-paper-front --project fluid-paper --debug

Expected behavior

Working with webframeworks enabled

Actual behavior

Needs vite