FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

upgrades the runtime to node20, now that 16 is EoL #344

Closed bkendall closed 5 months ago

github-actions[bot] commented 7 months ago

Visit the preview URL for this PR (updated for commit bbc39f0):

https://action-hosting-deploy-demo--pr344-bk-node20-mw7qfbq4.web.app

(expires Wed, 06 Mar 2024 20:40:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ca07ce2c831b1990b78fcf2ecdfe230a486dc973

testak-m commented 6 months ago

@bkendall @jhuleatt Can this pull request be merged and released? You can solve the following issues.

341

sam-golioth commented 6 months ago

@bkendall @jhuleatt Is there anything else we need to merge this PR?

huggsboson commented 6 months ago

@bkendall any chance you'll merge this soon?

testak-m commented 6 months ago

@bkendall @jhuleatt ping

thomasvht commented 5 months ago

Will someone have a look, because due to the EoL we have builds failing.

testak-m commented 5 months ago

@inlined Is it possible to merge this pull request? This action is used in firebase-tools.

thomasvht commented 5 months ago

@henrylangenhoven I see the changes are approved which is great. Is there someone who can merge the change? 😄

testak-m commented 5 months ago

@developit hello! I found your name in the author field. https://github.com/FirebaseExtended/action-hosting-deploy/blob/120e124148ab7016bec2374e5050f15051255ba2/action.yml#L17

I have a request for you, the author. Could you please merge and release this pull request? please!

developit commented 5 months ago

I don't have merge rights on this repo, sorry.

testak-m commented 5 months ago

@developit I understand your position. Thank you for checking.

testak-m commented 5 months ago

@jhuleatt Are you still busy? Don't have time to merge and release this pull request?

EricCheungAO commented 5 months ago

@jhuleatt Are you still busy? Don't have time to merge and release this pull request?

cc @jhuleatt

testak-m commented 5 months ago

He seems to be active. https://github.com/FirebaseExtended/firebase-framework-tools/pull/161

I was relieved to know that he was alive.

lesv commented 5 months ago

Does anyone know what version this is. The CLI is still generating FirebaseExtended/action-hosting-deploy@v0, is the updated one v1? (and has it been released to Github)

testak-m commented 5 months ago

@lesv It seems that it has been merged but not released. https://github.com/FirebaseExtended/action-hosting-deploy/releases

It has not been released and cannot be used in any version. v0 refers to v0.7.1.

testak-m commented 5 months ago

@jhuleatt Can you release it?

testak-m commented 5 months ago

@jamesdaniels @leoortizz @Yuangwang @sjjj986 @bkendall He seems busy. Can you guys help him make the release?

178inaba commented 5 months ago

I submitted a pull request to firebase-tools to specify the version by hash value. The warning should disappear once released. https://github.com/firebase/firebase-tools/pull/7025