search

FirebaseExtended / action-hosting-deploy

Automatically deploy shareable previews for your Firebase Hosting sites
https://firebase.google.com/docs/hosting/github-integration
Apache License 2.0
695 stars 202 forks source link

fix: Remove creation of the extra check and add support for GAC paths #353

Closed minherz closed 2 months ago

minherz commented 6 months ago

Removes creation of the additional action when this action is executed. Modifies the processing of GAC credentials to allow passing to the firebaseServiceAccount parameter both the path to the SA key as well as the JSON with credentials. Continues execution in absence of the firebase.json file to support "default" settings. Deletes the temporary file with credentials when it is created due to passing the credentials data in the firebaseServiceAccount parameter. Refactors log output to provide some more information and minimize the number of log groups. Updates README with additional paragraph that references a user to keyless authentication action. Refactors code to improve readability.

minherz commented 5 months ago

This implementation partially overlaps with #299. This implementation is more user friendly IMHO. Letting to use the input parameter to provide either the path to GAC or GAC info allows to support already configured workflows and also to use this action with google-github-action/auth

minherz commented 5 months ago

@jhuleatt I'd recommend to release it as v1 to distinguish from the current functionality in v0

minherz commented 2 months ago

Closing PR due to lack of activity. The implementation is available as the action minherz/firebase-hosting-deploy@v1