Updated $signInWithPopup() and $signInWithRedirect() docs

FirebaseExtended / angularfire

AngularJS bindings for Firebase

MIT License

2.73k stars 632 forks source link

Updated $signInWithPopup() and $signInWithRedirect() docs #896

Closed jwngr closed 7 years ago

jwngr commented 7 years ago

Description

Clarifies and adds additional examples to the reference docs for $signInWithPopup() and $signInWithRedirect().

Closes #894.

Code sample

N/A

coveralls commented 7 years ago

Coverage remained the same at 90.0% when pulling 3814b8ab19d9d35c59b47e371d8502202798d3a2 on jw-signin-docs-fixes into c22ef72f34e9ef390e33ba51975698fabd9907ad on master.

coveralls commented 7 years ago

Coverage increased (+3.7%) to 93.716% when pulling 88c290986d7730b7fcdaad5272134bbfc184a1cd on jw-signin-docs-fixes into c22ef72f34e9ef390e33ba51975698fabd9907ad on master.

katowulf commented 7 years ago

lgtm ☃