Closed kmturley closed 7 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Weird... We actually intentionally set the version number to 0.0.0
and do a string replace on that value when we cut new releases. So I'd prefer not to change it if we can avoid that. Do you know why jspm
pulls from the master
branch of the GitHub repo instead of from our tagged release commits like Bower?
Other registries like npm surely use the package.json version aswell? Maybe you can commit the updates?
I believe the default behaviour is that it will look at the master branch. However users can override it by using the semvar versioing format: https://github.com/jspm/jspm-cli/blob/master/docs/installing-packages.md
jspm install angularfire@^2.3.0
You can also submit an override to the jspm registry repo, which would set the default for every user: https://github.com/jspm/registry#submitting-a-package-override
We do commit the updated version number, but only for the commits which we tag as releases (e.g. https://github.com/firebase/angularfire/commit/8678f727648386019bc6fcaaadb7599ae064ca7b). I think I found a way to make it so that we don't need to use the 0.0.0
placeholder anymore in our release process though. Give me a little bit of time to fix that up and then we can get the version actual numbers back in the package.json
.
Cool, I've not done that with grunt before but it seems npm version is one of the best ways to do it. https://docs.npmjs.com/cli/version
There is a grunt bump plugin which can do it too
Description
Fixing the jspm install issue: https://github.com/firebase/angularfire/issues/857
Code sample
I added the package.json version (which jspm requires for installation)