FirebaseExtended / angularfire

AngularJS bindings for Firebase
MIT License
2.73k stars 632 forks source link

Update package.json version number #914

Closed kmturley closed 7 years ago

kmturley commented 7 years ago

Description

Fixing the jspm install issue: https://github.com/firebase/angularfire/issues/857

Code sample

I added the package.json version (which jspm requires for installation)

"version": "2.3.0",
googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


kmturley commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.716% when pulling 2514e3646f1adec27bbd2579909eb557b5884f59 on kmturley:master into e1dff6f6c695b1fbbac2dd1a9fefcaafc43263c2 on firebase:master.

jwngr commented 7 years ago

Weird... We actually intentionally set the version number to 0.0.0 and do a string replace on that value when we cut new releases. So I'd prefer not to change it if we can avoid that. Do you know why jspm pulls from the master branch of the GitHub repo instead of from our tagged release commits like Bower?

kmturley commented 7 years ago

Other registries like npm surely use the package.json version aswell? Maybe you can commit the updates?

I believe the default behaviour is that it will look at the master branch. However users can override it by using the semvar versioing format: https://github.com/jspm/jspm-cli/blob/master/docs/installing-packages.md

jspm install angularfire@^2.3.0

You can also submit an override to the jspm registry repo, which would set the default for every user: https://github.com/jspm/registry#submitting-a-package-override

jwngr commented 7 years ago

We do commit the updated version number, but only for the commits which we tag as releases (e.g. https://github.com/firebase/angularfire/commit/8678f727648386019bc6fcaaadb7599ae064ca7b). I think I found a way to make it so that we don't need to use the 0.0.0 placeholder anymore in our release process though. Give me a little bit of time to fix that up and then we can get the version actual numbers back in the package.json.

kmturley commented 7 years ago

Cool, I've not done that with grunt before but it seems npm version is one of the best ways to do it. https://docs.npmjs.com/cli/version

There is a grunt bump plugin which can do it too