search

FirebaseExtended / bolt

Bolt Compiler (Firebase Security and Modeling)
Apache License 2.0
897 stars 107 forks source link

allow wildcard properties in type statement #235

Open rbellens opened 6 years ago

rbellens commented 6 years ago

Currently it is not allowed to have both wildcard properties and fields. Therefore, it is not possible to define types that allow properties other than the ones defined in the type statement. Only workaround is to not use type statements and manually define the validate rules, which is very cumbersome. See also issues #212 and #213 .

This pull request allows a single wildcard property inside a type definition and when present disables the generation of the default validation rule that does not allow any field other than the ones defined.

dengjeffrey commented 5 years ago

@rbellens Are you still maintaining this PR? If not I might have some free time to continue where you left off

rbellens commented 5 years ago

@dengjeffrey feel free to do so

iamareebjamal commented 5 years ago

Can we have this feature soon, please :)

debkanchan commented 4 years ago

Hey can we revive this PR?

acorn1010 commented 4 years ago

The continuous-integration/travis-ci/pr failure from the integration check isn't related to this PR--it's an issue with gulp@3.9.1's dependency on graceful-fs.

Here's a detailed explanation on StackOverflow with some workarounds: https://stackoverflow.com/questions/55921442/how-to-fix-referenceerror-primordials-is-not-defined-in-node.