Closed khanhlvg closed 7 years ago
By the way we should also get a Reviewer for the Android and iOS code if you know any (unless you are super confident this is secure and good code :)
Thanks for the JS code review :) Yep, let me find someone to review the iOS and Android code.
Thanks @morganchen12 for reviewing the iOS sample app. I've made changes based on you feedback :)
@morganchen12 I agree that it'd be better to align to two-space indents with other Firebase repo, but I believe most iOS developers are using with Xcode default of four-space indents. As we want developers to reuse code in this sample (especially LineAuthManager), I'd prefer to use the Xcode default value so minimize developer effort when reusing the sample code.
I know I'm late to the party here, but I'm super happy to see this happen and look forward to the feedback from our Japanese devs! Thanks @khanhlvg @morganchen12 @samtstern @nicolasgarnier for making the dream come true 🎊 💥 🍾
@mcdonamp Thanks Mike :) I'm also really looking forward to feedback from Japanese devs!
Hi guys, thanks for your contribution here. Now, I know we could use Line login with firebase in IOS and Android. May I ask a naive question that is it possible to use Line login with firebase in pc browsers and smart phone browsers? BTW, I am doing devs in Japan now 😉
@demongaorui Yes, LINE Login seems to have an Web API. https://developers.line.me/web-api/technical-configuration
@demongaorui Yes this should be possible!
For an example of sign-in Firebase on the Web using a 3rd party OAuth provider you can have a look at the Instagram sample.
The places that need to be changed are:
LINE is the most popular messaging app in Japan, and some South East Asia countries.
I have built sample iOS and Android app to demonstrate how to integrate LINE Login to Firebase Auth.