search

FirebaseExtended / custom-auth-samples

Samples showcasing how to sign in Firebase using additional Identity Providers
Apache License 2.0
323 stars 97 forks source link

Kakao iOS integration #13

Closed CoderSpinoza closed 6 years ago

CoderSpinoza commented 6 years ago

This is a follow-up pull request after #6. This pull request contains

IOS sample application for Kakao and Firebase auth integration Better error handling in node.js custom token server Thanks for reviewing this! We will also do the web version soon :)

@nicolasgarnier

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

blomcheol commented 6 years ago

I confirm.

blomcheol commented 6 years ago

@morganchen12 Could you review the revisions? :)

blomcheol commented 6 years ago

@morganchen12 Could you review again? :)

morganchen12 commented 6 years ago

LGTM, thank you!