search

FirebaseExtended / custom-auth-samples

Samples showcasing how to sign in Firebase using additional Identity Providers
Apache License 2.0
323 stars 97 forks source link

Improved ways to link accounts #17

Open CoderSpinoza opened 6 years ago

CoderSpinoza commented 6 years ago

10 demonstrates developers' concerns with correctly linking custom oauth providers with users already signed in with privileged providers. @nicolasgarnier wrote a wonderful comment on how this can be achieved using Auth#setCustomUserClaims(uid, customClaims).

Although there is a limitation in this approach, compared to FirebaseUser#linkWithCredential() method, I assume this could be a fair guide to third-party developers for structuring complete auth system with multiple oauth providers including custom ones.

Could you review this pull request? @nicolasgarnier @samtstern

p.s. Token verification functionality was added to Kakao API so I also included it. :)

CoderSpinoza commented 6 years ago

@nicolasgarnier

Always thanks for your prompt review :) I added a new commit that contains several fixes you mentioned.

CoderSpinoza commented 6 years ago

@nicolasgarnier

Any update on this PR? :)

nicolasgarnier commented 6 years ago

Hey @CoderSpinoza sorry about that :) I'll get to it soon, I'm just done with a quite busy bunch of weeks.

CoderSpinoza commented 6 years ago

@nicolasgarnier Haha, guess you are busy these days! Just get to it whenever you are free :)

nicolasgarnier commented 6 years ago

Sorry for the delay ^^ I'll try to be faster next time :P

phs1919 commented 5 years ago

Any updates? :)

luizjunior05 commented 4 years ago

Any updates? This is very important.

fysoul17 commented 4 years ago

Waiting for updates too.

forresthopkinsa commented 3 years ago

Custom auth is not practical without the ability to merge accounts. +1