Update LINE Login custom auth sample to use firebase-admin

FirebaseExtended / custom-auth-samples

Samples showcasing how to sign in Firebase using additional Identity Providers

Apache License 2.0

323 stars 97 forks source link

Update LINE Login custom auth sample to use firebase-admin #4

Closed khanhlvg closed 7 years ago

khanhlvg commented 7 years ago

Changes made:

Update server-side module to use firebase-admin SDK
Fetch LINE profile to create Firebase user profile from server-side instead of client-side
Remove LINE profile fetching from client app (iOS & Android)

@nicolasgarnier As changes in iOS & Android code are only removing LINE profile fetching code that has been migrated to server-side, I think having you review server-side changes is enough. What do you think?

khanhlvg commented 7 years ago

@nicolasgarnier @samtstern @morganchen12 Thanks for your review :)

@nicolasgarnier I've fixed the code as your commented https://github.com/firebase/custom-auth-samples/pull/4/commits/f47741a808c309a6cacffbcbf8f9ba08d7b19d59

nicolasgarnier commented 7 years ago

LGTM!