FirebaseExtended / custom-auth-samples

Samples showcasing how to sign in Firebase using additional Identity Providers
Apache License 2.0
323 stars 97 forks source link

Invalid argument passed to createFireBaseAccount from Mobile App endpoint #5

Open noenthu opened 7 years ago

noenthu commented 7 years ago

Looks like in app.js line 142, we are passing the argument firebaseToken to the createFirebaseAccount function. This variable hasn't been created.

createFirebaseAccount(results.user.id, results.user.full_name,
        results.user.profile_picture, firebaseToken).then(firebaseToken => {
      // Send the custom token, access token and profile data as a JSON object.
      res.send(firebaseToken);

Think this should be a variable containing the access_token returned from the token endpoint for instagram.

Likely missing a

const accessToken = results.access_token;

createFirebaseAccount(results.user.id, results.user.full_name,
        results.user.profile_picture, accessToken).then(firebaseToken => {
      // Send the custom token, access token and profile data as a JSON object.
      res.send(firebaseToken);