FirebaseExtended / custom-auth-samples

Samples showcasing how to sign in Firebase using additional Identity Providers
Apache License 2.0
323 stars 97 forks source link

Kakao integration with Firebase Authentication #6

Closed CoderSpinoza closed 7 years ago

CoderSpinoza commented 7 years ago

KakaoTalk messenger, which is serviced by Kakao Corp., is a dominant messenger platform in South Korea and also globally expanding. We not only do messenger but also provide an API platform with a variety of APIs that eases user login, management, content sharing, etc

Recently, we are receiving lots of requests for Firebase integration with our Kakao Login API. Many companies and developers, who already own applications with Kakao Login API, are considering firebase as their platform choice for its merits.

It would be wonderful if an example app for integrating Kakao Login API with FIrebase Authentication is provided here for them to refer to.

Signed-off-by: Hara Kang kevin.kang@kakaocorp.com

CoderSpinoza commented 7 years ago

@samtstern When can this be reviewed? :)

samtstern commented 7 years ago

@CoderSpinoza sorry I totally missed this until your reminder! Will take a look.

samtstern commented 7 years ago

@nicolasgarnier can you review the JavaScript parts.

@CoderSpinoza bonus points if you make the NodeJS server into a Cloud Function! Then this would be even easier to deploy: https://firebase.google.com/docs/functions/

CoderSpinoza commented 7 years ago

@samtstern Thanks for your detailed reviews :) I have fixed everything you mentioned. Coud you review again please?

@nicolasgarnier Could you also review the node.js part? I will also look into Cloud function!

samtstern commented 7 years ago

@CoderSpinoza approved. I will let @nicolasgarnier merge after his last comment is resolved.

CoderSpinoza commented 7 years ago

@samtstern @nicolasgarnier I resolved the issue in the last comment. Could you consider merging? :)

There are several other issues I want to work on:

Thanks for helping :)

nicolasgarnier commented 7 years ago

Done and thanks so much for this :)