search

FirebaseExtended / fastlane-plugin-firebase_test_lab

Test your app with Firebase Test Lab with ease using fastlane
https://fastlane.tools
MIT License
74 stars 37 forks source link

Add app_path nil check to catch no app zip provided situation #40

Closed powerivq closed 6 years ago

powerivq commented 6 years ago

If the app_path is not provided, it would be defaulted to use the scan environment variable. If that is also nil, this nil check is needed to bail out.

KrauseFx commented 6 years ago

If we always want to require the variable to be set, we can update the optional value for this particular option (https://github.com/fastlane/fastlane-plugin-firebase_test_lab/blob/master/lib/fastlane/plugin/firebase_test_lab/options.rb#L15).

If it's just for this action, then yes, this change looks fine 👍

powerivq commented 6 years ago

@KrauseFx I thought it wouldn't check whether default_value is also nil. I just tested and I was wrong. optional seems to work great here.

KrauseFx commented 6 years ago

Cool 👍