FirebaseExtended / fastlane-plugin-firebase_test_lab

Test your app with Firebase Test Lab with ease using fastlane
https://fastlane.tools
MIT License
74 stars 37 forks source link

Added option to skip app validation before uploading #72

Closed bpollman closed 4 years ago

bpollman commented 4 years ago

Primary purpose is to enable uploading valid apps that this plugin is not yet aware of such as FormatVersion 2 seems to be used with test plans.

Other Options

While a more correct option may be to update the validation function to support this format. I think it makes sense to drop the validation feature all together and simply rely on Firebase Test Labs to do the validation which it performs anyway. This would remove one more thing that has be regularly updated to keep up with Xcode.

Sample xctestrun file where FormatVersion is 2

<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>TestConfigurations</key>
    <array>
        <dict>
            <key>Name</key>
            <string>Configuration 1</string>
            <key>TestTargets</key>
            <array>
                <dict>
                    <key>BlueprintName</key>
                    <string>redactedTests</string>
                    <key>BundleIdentifiersForCrashReportEmphasis</key>
                    <array>
                        <string>redacted.watchkitapp</string>
                        <string>redacted.share-extension</string>
                        <string>redacted.watchkitapp.watchkitextension</string>
                        <string>redacted</string>
                    </array>
                    <key>CommandLineArguments</key>
                    <array/>
                    <key>DependentProductPaths</key>
                    <array>
                        <string>__TESTROOT__/Release-iphoneos/share-extension.appex</string>
                        <string>__TESTROOT__/Release-iphoneos/redacted WatchKit</string>
                        <string>__TESTROOT__/Release-iphoneos/redacted WatchKit Extension</string>
                        <string>__TESTROOT__/Release-iphoneos/redacted.app</string>
                        <string>__TESTROOT__/Release-iphoneos/redactedTests-Runner.app/PlugIns/redactedTests.xctest</string>
                    </array>
                    <key>EnvironmentVariables</key>
                    <dict>
                        <key>OS_ACTIVITY_DT_MODE</key>
                        <string>YES</string>
                        <key>SQLITE_ENABLE_THREAD_ASSERTIONS</key>
                        <string>1</string>
                    </dict>
                    <key>IsUITestBundle</key>
                    <true/>
                    <key>IsXCTRunnerHostedTestBundle</key>
                    <true/>
                    <key>ProductModuleName</key>
                    <string>redactedTests</string>
                    <key>SkipTestIdentifiers</key>
                    <array>
                        <string>RedactedFeature</string>
                    </array>
                    <key>SystemAttachmentLifetime</key>
                    <string>deleteOnSuccess</string>
                    <key>TestBundlePath</key>
                    <string>__TESTHOST__/PlugIns/redactedTests.xctest</string>
                    <key>TestHostBundleIdentifier</key>
                    <string>.xctrunner</string>
                    <key>TestHostPath</key>
                    <string>__TESTROOT__/Release-iphoneos/redactedTests-Runner.app</string>
                    <key>TestLanguage</key>
                    <string></string>
                    <key>TestRegion</key>
                    <string></string>
                    <key>TestingEnvironmentVariables</key>
                    <dict>
                        <key>DYLD_FALLBACK_FRAMEWORK_PATH</key>
                        <string></string>
                    </dict>
                    <key>ToolchainsSettingValue</key>
                    <array/>
                    <key>UITargetAppCommandLineArguments</key>
                    <array/>
                    <key>UITargetAppEnvironmentVariables</key>
                    <dict/>
                    <key>UITargetAppPath</key>
                    <string>__TESTROOT__/Release-iphoneos/redacted.app</string>
                    <key>UserAttachmentLifetime</key>
                    <string>deleteOnSuccess</string>
                </dict>
            </array>
        </dict>
    </array>
    <key>__xctestrun_metadata__</key>
    <dict>
        <key>FormatVersion</key>
        <integer>2</integer>
    </dict>
</dict>
</plist>
googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

bpollman commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Vyazovoy commented 4 years ago

Hi! When will this useful changes be released and published?