search

FirebaseExtended / fastlane-plugin-firebase_test_lab

Test your app with Firebase Test Lab with ease using fastlane
https://fastlane.tools
MIT License
74 stars 37 forks source link

Add custom messaging for invalid FTL matrices #9

Closed powerivq closed 6 years ago

powerivq commented 6 years ago

@nakhbari : We can provide better understanding of why the matrix was considered invalid. There is an InvalidMatrixDetails property here that maps to an enum. We can copy the gcloud error messages https://github.com/google-cloud-sdk/google-cloud-sdk/blob/e835d123ad6067a5520a0802456357e45571d026/lib/googlecloudsdk/api_lib/firebase/test/tool_results.py#L114

powerivq commented 6 years ago

Fixed by https://github.com/fastlane/fastlane-plugin-firebase_test_lab/commit/f9d44fed8a2a7475dc0260b609ccff4c2199525c

nakhbari commented 6 years ago

We could still use some work here. We should still get the details from the Invalid Matrix Details and use similar error messaging as the gcloud and Firebase Console UI.

powerivq commented 6 years ago

https://github.com/fastlane/fastlane-plugin-firebase_test_lab/pull/45