search

FirebaseExtended / firebase-arduino

Arduino samples for Firebase.
Apache License 2.0
945 stars 494 forks source link

Refactor github repositories. #118

Open ed7coyne opened 8 years ago

ed7coyne commented 8 years ago

I think we should change to three github projects.

FirebaseArduino - Will include the FirebaseArduino.{h,cc} and all related examples. Will be exported as an Arduino library. FirebaseArduinoModem - Will include SerialTransciever.h and modem/ subdirs including tests, and its example. Will be exported as an Arduino Library. firebase-iot - Will include the core cross-platform logic (Firebase.{h,cc}, transports, etc..) and tests.

I think they should all live under google/ as well instead of googlesamples/ as we are providing libraries to use instead of samples.

This issue will preclude #108 and #92.

What do you think?

ed7coyne commented 8 years ago

I think we should then use submodules to include firebase-iot in the two libraries and add symlinks. The issues with windows and symlinks will just have to be addressed by windows developers I don't think there is any other great way to include part of another library.

proppy commented 8 years ago

what about splitting them logically in the same repo for now?

It will be easier to version and to manage since we'll get atomic commit on the 3 codebases. We can always split later when the projects grows larger.

ed7coyne commented 8 years ago

I was hoping to do just that but I don't think we can release Arduino libraries that way.

ed7coyne commented 8 years ago

I am thinking we could do some shenanigans like do all of our development in firebase-iot (main repo, not an arduino library). Then create the other two repos FirebaseArduino and FirebaseArduinoModem, import firebase-iot as a submodule into them and use symlinks to create the structure that arduino wants for its libraries in those dummy repos.