search

FirebaseExtended / firebase-auth-migration-helpers

Other
11 stars 16 forks source link

Fixes migrate callback running multiple times #9

Open bakertim opened 8 years ago

bakertim commented 8 years ago

Fixes a bug where if someone is already authenticated with the current Firebase SDK migrate: would run the callback twice.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

bakertim commented 8 years ago

I signed it!

On Aug 4, 2016, at 9:28 AM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/. If you signed the CLA as a corporation, please let us know the company's name. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/firebase/firebase-auth-migration-helpers/pull/9#issuecomment-237552520, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnvjWZr3i-WEgPmL_tFVa731hR3tIZGks5qcekCgaJpZM4JcsfK.

googlebot commented 8 years ago

CLAs look good, thanks!